Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the record scope of tx-pool reject record and fix rule for orphan tx. #4511

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Modify the record scope of tx-pool reject record and fix rule for orphan tx. #4511

merged 4 commits into from
Jul 15, 2024

Conversation

zhangsoledad
Copy link
Member

What problem does this PR solve?

  • Modify the record scope of tx-pool reject record, Now that all rejects are record except Duplicate (which gets rebroadcast)
  • Fixed the case where some inputs of a transaction are unknown will not add to the orphan pool.
  • Now actively fetches unknown transactions from node broadcasting orphan tx

Check List

Tests

  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner July 9, 2024 07:58
@zhangsoledad zhangsoledad requested review from doitian and removed request for a team July 9, 2024 07:58
eval-exec
eval-exec previously approved these changes Jul 10, 2024
View reviewed changes
@zhangsoledad zhangsoledad mentioned this pull request Jul 15, 2024
Closed
@doitian doitian added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@doitian doitian added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@zhangsoledad zhangsoledad added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@zhangsoledad zhangsoledad added this pull request to the merge queue Jul 15, 2024
Merged via the queue into develop with commit 2c3cfb9 Jul 15, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@eval-exec eval-exec Awaiting requested review from eval-exec

Assignees
No one assigned
Labels
m:tx-pool
Projects
CKB Kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @doitian @eval-exec